Unified implementation of BasicObject#instance_eval and Module#module_eval
#6579
Conversation
…ule_eval` Their implementation logic is almost identical.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @dearblue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on refactoring the internal implementation of BasicObject#instance_eval and Module#module_eval by consolidating their shared logic into a single, unified helper function. This change aims to reduce code duplication and improve the maintainability of the evaluation mechanism within the system.
Highlights
- Code Refactoring: Introduced a new static helper function,
object_eval, to centralize the common logic previously duplicated acrossBasicObject#instance_evalandModule#module_eval(implemented asf_class_eval). - Simplified
instance_eval: Thef_instance_evalfunction has been refactored to delegate its execution logic to the newly introducedobject_evalfunction, passingFALSEfor theclass_evalflag. - Simplified
module_eval: Thef_class_evalfunction (which implementsModule#module_eval) has been refactored to delegate its execution logic to the newobject_evalfunction, passingTRUEfor theclass_evalflag.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the implementations of instance_eval and module_eval to reduce code duplication. A new static function object_eval is introduced to hold the common logic for handling both string and block arguments. The change is a good improvement for maintainability. I've pointed out one high-severity issue regarding the use of undeclared internal functions, which should be addressed by adding forward declarations.
| { | ||
| if (mrb_block_given_p(mrb)) { | ||
| mrb_get_args(mrb, ""); | ||
| return class_eval ? mrb_mod_module_eval(mrb, self) : mrb_obj_instance_eval(mrb, self); |
There was a problem hiding this comment.
The functions mrb_mod_module_eval and mrb_obj_instance_eval are used here but are not declared in any header file. They appear to be internal functions from src/vm.c. This creates an implicit dependency that is fragile and can lead to build or runtime errors if the function signatures change in the future.
To make this dependency explicit and avoid potential compiler warnings or errors, please add forward declarations for these functions at the top of this file, similar to how it's done for functions from mruby-binding.
/* from src/vm.c */
mrb_value mrb_mod_module_eval(mrb_state *mrb, mrb_value mod);
mrb_value mrb_obj_instance_eval(mrb_state *mrb, mrb_value self);
2 participants
Their implementation logic is almost identical.