Skip to content

Conversation

@dearblue
Copy link
Contributor

The MRuby::Build#libmruby_core_only_objs accessor has been added for this purpose. It probably does not make sense for users to use this accessor.

And, the mruby-bin-mrbc/src/stub.c file has been moved to mruby/src/coreonly/stub.c. The object files generated from this file are passed to the newly created accessor.

@matz
Copy link
Member

matz commented Jun 24, 2023

I agree with the basic idea of this pull-request. But I don't like the directory name coreonly which role is not clear from the directory name.

@dearblue
Copy link
Contributor Author

Thanks for your comment.
🤔 Hmmm, is src/libmruby_core/ acceptable?

@matz
Copy link
Member

matz commented Jun 27, 2023

src/nogem maybe?

@dearblue
Copy link
Contributor Author

MRB_NO_GEMS may be defined in libmruby.a builds.

# build configuration
MRuby::Build.new do
  toolchain
end

Also, I don't think libmruby_core.a is very good about nogem since it doesn't include mruby/mrblib.

However, if you think src/nogem is OK, I will update this patch accordingly.

The `MRuby::Build#libmruby_core_only_objs` accessor has been added for this purpose.
It probably does not make sense for users to use this accessor.

And, the `mruby-bin-mrbc/src/stub.c` file has been moved to `mruby/src/nogem/stub.c`.
The object files generated from this file are passed to the newly created accessor.
@matz
Copy link
Member

matz commented Sep 20, 2024

I still feel unclear about what the term libmruby_core_only_objs means and what it is used for. Please explain a little more. Japanese is fine.

@dearblue
Copy link
Contributor Author

すでに libmruby_core_objs がありますが、これは libmruby_objs の一部としても使われています。

mruby/lib/mruby/build.rb

Lines 121 to 122 in bd668e4

@libmruby_core_objs = []
@libmruby_objs = [@libmruby_core_objs]

libmruby_core_objs を別の名前に変更する場合は互換性の面で少し気になったため、( (libmruby_core + only) + objs) という名前で提案しました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants