raise ZeroDivisionError instead of crashing. #492
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) On OpenBSD/amd64, mruby dumps core when we call Integer#divmod with 0:
In contrast, CRuby raises an exception:
Integer#divmod is not defined in ISO Ruby but CRuby's behavior looks reasonable.
b) Integer#% and Float#% may return NaN:
But ISO Ruby says that "i % 0" should raise a ZeroDivisionError exception. CRuby implements that.
This pull-request makes Fixnum#%, Float#% and Fixnum#divmod compatible with CRuby.