numeric.c: restore fmt argument for backward compatibility.

matz · matz · commit 7c8a91ff5a41 · 2021-06-15T16:19:16.000+09:00
`mrb_float_to_str()` used to take `fmt` argument. We thought no one used
the function, and OK to remove the argument. But at least `mruby-redis`
gem used the function.
diff --git a/include/mruby/numeric.h b/include/mruby/numeric.h
@@ -166,7 +166,7 @@ MRB_API mrb_float mrb_as_float(mrb_state *mrb, mrb_value x);
 
 /* internal functions */
 mrb_float mrb_div_float(mrb_float x, mrb_float y);
-mrb_value mrb_float_to_str(mrb_state *mrb, mrb_value x);
+mrb_value mrb_float_to_str(mrb_state *mrb, mrb_value x, const char *fmt);
 int mrb_format_float(mrb_float f, char *buf, size_t buf_size, char fmt, int prec, char sign);
 
 /* obsolete functions; will be removed */
diff --git a/src/numeric.c b/src/numeric.c
@@ -277,8 +277,9 @@ flo_div(mrb_state *mrb, mrb_value x)
   return mrb_float_value(mrb, a);
 }
 
-MRB_API mrb_value
-mrb_float_to_str(mrb_state *mrb, mrb_value flo)
+/* the argument `fmt` is no longer used; you can pass `NULL` */
+mrb_value
+mrb_float_to_str(mrb_state *mrb, mrb_value flo, const char *fmt)
 {
   char buf[25];
 #ifdef MRB_USE_FLOAT32
@@ -330,7 +331,7 @@ flo_to_s(mrb_state *mrb, mrb_value flt)
     str = mrb_str_new_lit(mrb, "NaN");
   }
   else {
-    str = mrb_float_to_str(mrb, flt);
+    str = mrb_float_to_str(mrb, flt, NULL);
   }
 
   RSTR_SET_ASCII_FLAG(mrb_str_ptr(str));

Original file line number	Diff line number	Diff line change
`@@ -277,8 +277,9 @@ flo_div(mrb_state *mrb, mrb_value x)`
`277`	`277`	`return mrb_float_value(mrb, a);`
`278`	`278`	`}`
`279`	`279`
`280`		`-MRB_API mrb_value`
`281`		`-mrb_float_to_str(mrb_state *mrb, mrb_value flo)`
	`280`	+/* the argument `fmt` is no longer used; you can pass `NULL` */
	`281`	`+mrb_value`
	`282`	`+mrb_float_to_str(mrb_state mrb, mrb_value flo, const char fmt)`
`282`	`283`	`{`
`283`	`284`	`char buf[25];`
`284`	`285`	`#ifdef MRB_USE_FLOAT32`
`@@ -330,7 +331,7 @@ flo_to_s(mrb_state *mrb, mrb_value flt)`
`330`	`331`	`str = mrb_str_new_lit(mrb, "NaN");`
`331`	`332`	`}`
`332`	`333`	`else {`
`333`		`- str = mrb_float_to_str(mrb, flt);`
	`334`	`+ str = mrb_float_to_str(mrb, flt, NULL);`
`334`	`335`	`}`
`335`	`336`
`336`	`337`	`RSTR_SET_ASCII_FLAG(mrb_str_ptr(str));`