Skip to content

Use math.isqrt in isqrt_python calculations #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skirpichev merged 2 commits into from
May 10, 2023
+7 −3
Merged

Use math.isqrt in isqrt_python calculations #695

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45783c1
Use `math.isqrt` in `isqrt_python` calculations
haru-44 May 8, 2023
42570bb
If the python version is 3.12 or higher, we just use `math.isqrt`
haru-44 May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions mpmath/libmp/libintmath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"""

import math
import sys
from bisect import bisect

from .backend import BACKEND, gmpy, sage, sage_utils, MPZ, MPZ_ONE, MPZ_ZERO
Expand Down Expand Up @@ -316,9 +317,12 @@ def sqrt_fixed(x, prec):
getattr(sage_utils, "isqrt", lambda n: MPZ(n).isqrt())
sqrtrem = lambda n: MPZ(n).sqrtrem()
else:
isqrt_small = isqrt_small_python
isqrt_fast = isqrt_fast_python
isqrt = isqrt_python
if sys.version_info >= (3, 12):
isqrt_small = isqrt_fast = isqrt = math.isqrt
else:
isqrt_small = isqrt_small_python
isqrt_fast = isqrt_fast_python
isqrt = isqrt_python
sqrtrem = sqrtrem_python


Expand Down