Skip to content

removed php 8.5 deprecation curl_close#2121

Closed
brainfoolong wants to merge 1 commit into
mpdf:developmentfrom
brainfoolong:development
Closed

removed php 8.5 deprecation curl_close#2121
brainfoolong wants to merge 1 commit into
mpdf:developmentfrom
brainfoolong:development

Conversation

@brainfoolong
Copy link
Copy Markdown

@finwe
Copy link
Copy Markdown
Member

finwe commented Aug 20, 2025

And what about earlier versions of PHP? 🙃

@brainfoolong
Copy link
Copy Markdown
Author

brainfoolong commented Aug 20, 2025

Since v Php 8.0 this function does nothing -> https://www.php.net/manual/en/function.curl-close.php
Edit: Prior to 8.0, curl handles are closed automatically anyway on script shutdown, so it was not explicitely required even before 8.0

@finwe
Copy link
Copy Markdown
Member

finwe commented Aug 20, 2025

mPDF is officially supported from PHP 5.6
Edit: I'd like the function to be called when appropriate, in case of longer running scripts. Just as imagedestroy was handled

@brainfoolong
Copy link
Copy Markdown
Author

I understand. In this case, i close this PR. I don't have time now to do this in the more proper way.

@finwe
Copy link
Copy Markdown
Member

finwe commented Aug 20, 2025

shame, but thanks for the initial effort anyway.

@ddevsr
Copy link
Copy Markdown
Contributor

ddevsr commented Aug 25, 2025

I create new PR #2122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants