Provide standardized way to run checks and format results#84
Closed
grahamalama wants to merge 9 commits intomainfrom
Closed
Provide standardized way to run checks and format results#84grahamalama wants to merge 9 commits intomainfrom
grahamalama wants to merge 9 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 97.80% 98.34% +0.54%
==========================================
Files 18 18
Lines 591 605 +14
Branches 85 84 -1
==========================================
+ Hits 578 595 +17
+ Misses 9 7 -2
+ Partials 4 3 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
Looks like this PR needs some test tweaks to account for the changes. Going to start those now, but I wouldn't hate an early review. I'm planning on landing this, and maybe a follow-on PR to centralize check registration as well before turning my attention back to the FastAPI integration, since I think these PRs will affect that implementation. |
- use client instead of request factory - automatically clear registry, and don't handle Django version <2 - test response content when debug is enabled and disabled
Contributor
Author
|
Closing this and recreating with the PR I was going to submit as a follow-on, but makes sense to add on top of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides functions and dataclasses in the
dockerflow.checkspackage to run registered checks (both synchronously and asynchronously) and return the results of the checks in a standardized manner.