@marco-c @Luni-4 before merging this, I think we have to first merge mozilla/rust-code-analysis-output#5

@alexle0nte merged it!

@alexle0nte merged it!

Thanks! I synced the submodule. Now it's ready for review

There are a few test failures, for example https://community-tc.services.mozilla.com/tasks/Dk7Mn21LRpWpwePp_KHCew/runs/0/logs/public/logs/live.log.

There are a few test failures, for example https://community-tc.services.mozilla.com/tasks/Dk7Mn21LRpWpwePp_KHCew/runs/0/logs/public/logs/live.log.

Yes, this test fails due to a parsing error in tree-sitter-cpp. I have opened an issue to report it: tree-sitter/tree-sitter-cpp#307

Same for https://community-tc.services.mozilla.com/tasks/ViJGwdjsR-2f322NYxBvSQ/runs/0/logs/public/logs/live.log?

Yes, all these pdf.js tests fail due to the same parsing error in tree-sitter-javascript. As I was suggesting the other day, after merging this PR, I can open issues to report the failing tests and their causes, linking the corresponding grammar parsing error issue for each of them

OK, thanks. Just wanted to confirm these were all known!

Looks good to me overall. @Luni-4 do you want to take a look too?

Thanks a lot for your hard work @alexle0nte! This is fine for me too!

@alexle0nte and @marco-c

Just a question we can treat in another PR perhaps: How can we make the CI green? Since tests do not pass, now it is impossible to publish a new version of rca for example.

I think we can temporarily ignore the failing tests and add a comment explaining the reason, as well as a link to the issue we will open.

I agree with this plan

It would be ideal to mark the failing tests as failing, so the CI is green and we notice if there is a new failure in addition to the known ones (otherwise the new failures will be lost in the noise).
We can do this in a follow-up.

@alexle0nte could you file issues for the failing tests and link to the upstream grammar issues?