Conversation
marco-c
reviewed
Dec 19, 2023
marco-c
reviewed
Dec 19, 2023
marco-c
reviewed
Dec 19, 2023
marco-c
reviewed
Dec 19, 2023
Luni-4
force-pushed
the
document-grammar
branch
from
5569c0f to
ecc6fd8
Compare
Collaborator
|
Looks good to me, but could you try to do a grammar update following the steps here to make sure nothing was missed? |
Collaborator
Author
|
Sure! I'm going to add |
Collaborator
|
@Luni-4 ping :) |
Collaborator
|
@alexle0nte did you follow the steps documented here for #1086? Is there anything missing that we should add? |
Contributor
Yes, I followed these steps. Regarding the update of grammar versions, the guide is complete. If I notice anything missing while fixing the tests, I'll report it |
Collaborator
|
Perfect, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #979
It adds to the developer section of the book a guide to update both third-party grammars and internal grammars.