chore: rely on nss-rs for NSS initialization and test DB#3621
Draft
larseggert wants to merge 1 commit into
Draft
chore: rely on nss-rs for NSS initialization and test DB#3621larseggert wants to merge 1 commit into
larseggert wants to merge 1 commit into
Conversation
Collaborator
Author
|
Depends on mozilla/nss-rs#56 |
Delegate NSS init in `fixture_init` to `nss-rs`'s own `test-fixture` crate instead of duplicating the logic. Remove `test-fixture/db` — the NSS database now comes from `nss-rs`, which exposes `TEST_FIXTURE_DB` as the default path for `neqo-server --db`. Update CI and scripts accordingly.
larseggert
force-pushed
the
chore-simplify-nss-init
branch
from
4824dad to
9f9ba48
Compare
Contributor
Failed Interop TestsNone ❓ All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as clientNone ❓ neqo-pr as serverNone ❓ Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as clientNone ❓ neqo-pr as serverNone ❓ |
martinthomson
approved these changes
May 15, 2026
Member
martinthomson
left a comment
martinthomson
left a comment
There was a problem hiding this comment.
I can't see a problem here, other than the challenge of finding the db from the NSS crate (which I hope the tests will sort out)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegate NSS init in
fixture_inittonss-rs's owntest-fixturecrate instead of duplicating the logic. Removetest-fixture/db— the NSS database now comes fromnss-rs, which exposesTEST_FIXTURE_DBas the default path forneqo-server --db. Update CI and scripts accordingly.