-
Notifications
You must be signed in to change notification settings - Fork 803
Create missing tranlsations for enabled locales #6949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
akatsoulas
commented
Oct 8, 2025
- Automatically approve AI based revisions for archived documents
- Introduce a query builder for l10n
- Refactor services
- Update strategy routing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces comprehensive localization automation features by adding missing translation creation capabilities, refactoring translation services with a query builder architecture, and implementing smart document-aware routing for hybrid locales.
- Added new
MissingTranslationServiceandcreate_missing_translationstask to create initial translations for untranslated documents - Introduced
TranslationQueryBuilderto centralize translation discovery queries and refactored existing services to use a sharedBaseTranslationService - Enhanced strategy routing to automatically use AI flow for archived documents in hybrid locales instead of requiring human review
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| kitsune/wiki/services.py | Major refactoring introducing query builder pattern, base service class, and new missing translation service |
| kitsune/wiki/strategies.py | Enhanced routing logic to handle archived documents in hybrid locales with AI flow |
| kitsune/wiki/tasks.py | Added new periodic task for creating missing translations and updated existing task method call |
| kitsune/wiki/tests/test_services.py | Comprehensive test coverage for new query builder, strategy factory routing, and translation services |
| docs/l10n-system.md | Updated documentation explaining new services, document-aware routing, and usage examples |
Comments suppressed due to low confidence (1)
kitsune/wiki/tasks.py:1
- Corrected spelling of 'tranlsations' to 'translations'.
import logging
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'm adding my comments so far, and will continue my review tomorrow.
* Automatically approve AI based revisions for archived documents * Introduce a query builder for l10n * Refactor services * Update strategy routing
b3970c5 to
63fad0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work! r+ with a tiny comment.
| ``` | ||
|
|
||
| Creates initial translations for English documents that don't have translations yet. Uses document-aware routing: | ||
| - AI locales: translates all documents (archived and non-archived) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding and auto-publishes?
- AI locales: translates and auto-publishes all documents (archived and non-archived)