Skip to content

Conversation

@akatsoulas
Copy link
Collaborator

  • Automatically approve AI based revisions for archived documents
  • Introduce a query builder for l10n
  • Refactor services
  • Update strategy routing

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces comprehensive localization automation features by adding missing translation creation capabilities, refactoring translation services with a query builder architecture, and implementing smart document-aware routing for hybrid locales.

  • Added new MissingTranslationService and create_missing_translations task to create initial translations for untranslated documents
  • Introduced TranslationQueryBuilder to centralize translation discovery queries and refactored existing services to use a shared BaseTranslationService
  • Enhanced strategy routing to automatically use AI flow for archived documents in hybrid locales instead of requiring human review

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
kitsune/wiki/services.py Major refactoring introducing query builder pattern, base service class, and new missing translation service
kitsune/wiki/strategies.py Enhanced routing logic to handle archived documents in hybrid locales with AI flow
kitsune/wiki/tasks.py Added new periodic task for creating missing translations and updated existing task method call
kitsune/wiki/tests/test_services.py Comprehensive test coverage for new query builder, strategy factory routing, and translation services
docs/l10n-system.md Updated documentation explaining new services, document-aware routing, and usage examples
Comments suppressed due to low confidence (1)

kitsune/wiki/tasks.py:1

  • Corrected spelling of 'tranlsations' to 'translations'.
import logging

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm adding my comments so far, and will continue my review tomorrow.

* Automatically approve AI based revisions for archived documents
* Introduce a query builder for l10n
* Refactor services
* Update strategy routing
@akatsoulas akatsoulas force-pushed the auto-translate-archived branch from b3970c5 to 63fad0b Compare October 9, 2025 09:32
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! r+ with a tiny comment.

```

Creates initial translations for English documents that don't have translations yet. Uses document-aware routing:
- AI locales: translates all documents (archived and non-archived)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding and auto-publishes?

- AI locales: translates and auto-publishes all documents (archived and non-archived)

@akatsoulas akatsoulas merged commit a92afad into mozilla:main Oct 13, 2025
2 checks passed
@akatsoulas akatsoulas deleted the auto-translate-archived branch October 13, 2025 09:23
@mozilla mozilla deleted a comment Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants