Add a stage for l10n files #6906
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the Docker build process by introducing a dedicated stage for generating localization (l10n) files, specifically jsi18n files, and reordering the build stages for better dependency management.
- Adds a new
jsi18n-generatorstage that handles localization file generation before frontend building - Reorders stages so localization files are generated first, then copied to the frontend builder
- Updates stage numbering and comments throughout the Dockerfile to reflect the new structure
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY package*.json ./ |
There was a problem hiding this comment.
The change from npm install to npm ci is good for reproducible builds, but this should be applied consistently. The original frontend-builder stage used npm install, so this change should be intentional and documented if it represents a shift in build strategy.
| COPY package*.json ./ | |
| COPY package*.json ./ | |
| # Use `npm ci` instead of `npm install` for reproducible builds. | |
| # This is an intentional shift in build strategy to ensure dependencies are installed exactly as specified in package-lock.json. |
| COPY . . | ||
| COPY --from=jsi18n-generator /app/jsi18n ./jsi18n | ||
|
|
||
| RUN cp .env-build .env && \ |
There was a problem hiding this comment.
The webpack build commands are missing the mkdir -p jsi18n/jsi18n command that was present in the original frontend-builder stage. Since jsi18n files are now copied from the jsi18n-generator stage, verify that this directory creation is no longer needed, or if the copied files maintain the expected directory structure.
| RUN cp .env-build .env && \ | |
| RUN cp .env-build .env && \ | |
| mkdir -p jsi18n/jsi18n && \ |
1 participant
No description provided.