Merge pull request #57 from mdboom/fix-oath-client-id

jezdez · web-flow · commit 7801247cd93a · 2018-02-07T21:48:20.000+01:00
Fix #53, Fix #56: Don't corrupt notebook.json when no oauth_client_id
diff --git a/setup.py b/setup.py
@@ -15,6 +15,7 @@
         'notebook >= 4.2',
         'jupyter',
         'requests',
+        'six',
         'widgetsnbextension',
     ],
     url='https://github.com/mozilla/jupyter-notebook-gist',
diff --git a/src/jupyter_notebook_gist/config.py b/src/jupyter_notebook_gist/config.py
@@ -1,3 +1,4 @@
+import six
 from traitlets.config import LoggingConfigurable
 from traitlets.traitlets import Unicode
 
@@ -19,6 +20,9 @@ def __init__(self, *args, **kwargs):
         super(NotebookGist, self).__init__(*args, **kwargs)
         # update the frontend settings with the currently passed
         # OAUTH client id
+        client_id = self.config.NotebookGist.oauth_client_id
+        if not isinstance(client_id, six.string_types):
+            client_id = None
         self.config_manager.update('notebook', {
-            'oauth_client_id': self.config.NotebookGist.oauth_client_id,
+            'oauth_client_id': client_id,
         })
