Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 63bf99b

Browse files
ArthurSonzognimoz-wptsync-bot
ArthurSonzogni
authored and
moz-wptsync-bot
committed
Bug 1712758 [wpt PR 29102] - [Credentialless]: WPT vs CacheStorage. 2 cases about "omit"., a=testonly
Automatic update from web-platform-tests [Credentialless]: WPT vs CacheStorage. 2 cases about "omit". On w3c/ServiceWorker#1592 (comment) I mentioned 5 "interesting" cases about `COEP:credentialless` and CacheStorage. All are already tested, except the 4th. This patch introduces two new tests with request.credentials="omit", including the missing one above. R=antoniosartori@chromium.org CC: clamy@chromium.org CC: mkwst@chromium.org CC: lyf@chromium.org Bug: 1175099 Change-Id: If8ea3ebc9efd6622be0d8c4dae7eba1bb28ce3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2917020 Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#886703} -- wpt-commits: b7a876caf70a8124d66f1a112d39c3712b2fa125 wpt-pr: 29102
1 parent 749b623 commit 63bf99b

1 file changed

Lines changed: 77 additions & 13 deletions

File tree

‎testing/web-platform/tests/html/cross-origin-embedder-policy/credentialless/cache-storage.tentative.https.html‎

Lines changed: 77 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
storer,
1919
retriever,
2020
resource_headers,
21+
request_credential_mode,
2122
expectation
2223
) => {
2324
promise_test_parallel(async test => {
@@ -30,7 +31,10 @@
3031
// CacheStorage.
3132
send(storer, `
3233
const cache = await caches.open("v1");
33-
const fetch_request = new Request("${url}", {mode: 'no-cors'});
34+
const fetch_request = new Request("${url}", {
35+
mode: 'no-cors',
36+
credentials: '${request_credential_mode}'
37+
});
3438
const fetch_response = await fetch(fetch_request);
3539
await cache.put(fetch_request, fetch_response);
3640
send("${this_token}", "stored");
@@ -62,30 +66,90 @@
6266
const context_require_corp = constructor(coep_require_corp);
6367

6468
cacheStorageTest(`[${environment}] unsafe-none => unsafe-none`,
65-
context_none, context_none, "", "retrieved");
69+
context_none,
70+
context_none,
71+
"",
72+
"include",
73+
"retrieved");
6674
cacheStorageTest(`[${environment}] unsafe-none => credentialless`,
67-
context_none, context_credentialless, "", "error");
75+
context_none,
76+
context_credentialless,
77+
"",
78+
"include",
79+
"error");
80+
cacheStorageTest(`[${environment}] unsafe-none => credentialless (omit)`,
81+
context_none,
82+
context_credentialless,
83+
"",
84+
"omit",
85+
"retrieved");
6886
cacheStorageTest(`[${environment}] unsafe-none => credentialless + CORP`,
69-
context_none, context_credentialless, corp_cross_origin, "retrieved");
87+
context_none,
88+
context_credentialless,
89+
corp_cross_origin,
90+
"include",
91+
"retrieved");
7092
cacheStorageTest(`[${environment}] unsafe-none => require-corp`,
71-
context_none, context_require_corp, "", "error");
93+
context_none,
94+
context_require_corp,
95+
"",
96+
"include",
97+
"error");
98+
cacheStorageTest(`[${environment}] unsafe-none => require-corp (omit)`,
99+
context_none,
100+
context_require_corp,
101+
"",
102+
"include",
103+
"error");
72104
cacheStorageTest(`[${environment}] unsafe-none => require-corp + CORP`,
73-
context_none, context_require_corp, corp_cross_origin, "retrieved");
105+
context_none,
106+
context_require_corp,
107+
corp_cross_origin,
108+
"include",
109+
"retrieved");
74110

75111
cacheStorageTest(`[${environment}] credentialless => unsafe-none`,
76-
context_credentialless, context_none, "", "retrieved");
112+
context_credentialless,
113+
context_none,
114+
"",
115+
"include",
116+
"retrieved");
77117
cacheStorageTest(`[${environment}] credentialless => credentialless`,
78-
context_credentialless, context_credentialless, "", "retrieved");
118+
context_credentialless,
119+
context_credentialless,
120+
"",
121+
"include",
122+
"retrieved");
79123
cacheStorageTest(`[${environment}] credentialless => require-corp`,
80-
context_credentialless, context_require_corp, "", "error");
124+
context_credentialless,
125+
context_require_corp,
126+
"",
127+
"include",
128+
"error");
81129
cacheStorageTest(`[${environment}] credentialless => require-corp + CORP`,
82-
context_credentialless, context_require_corp, corp_cross_origin, "retrieved");
130+
context_credentialless,
131+
context_require_corp,
132+
corp_cross_origin,
133+
"include",
134+
"retrieved");
83135

84136
cacheStorageTest(`[${environment}] require_corp => unsafe-none`,
85-
context_require_corp, context_none, corp_cross_origin, "retrieved");
137+
context_require_corp,
138+
context_none,
139+
corp_cross_origin,
140+
"include",
141+
"retrieved");
86142
cacheStorageTest(`[${environment}] require_corp => credentialless`,
87-
context_require_corp, context_credentialless, corp_cross_origin, "retrieved");
143+
context_require_corp,
144+
context_credentialless,
145+
corp_cross_origin,
146+
"include",
147+
"retrieved");
88148
cacheStorageTest(`[${environment}] require_corp => require-corp`,
89-
context_require_corp, context_require_corp, corp_cross_origin, "retrieved");
149+
context_require_corp,
150+
context_require_corp,
151+
corp_cross_origin,
152+
"include",
153+
"retrieved");
90154

91155
</script>

0 commit comments

Comments
 (0)