adds tagging on new and updated functions#508
Merged
DeviaVir merged 6 commits intomotdotla:masterfrom Dec 9, 2019
checkly:add-tags
Merged
adds tagging on new and updated functions#508DeviaVir merged 6 commits intomotdotla:masterfrom checkly:add-tags
DeviaVir merged 6 commits intomotdotla:masterfrom
checkly:add-tags
Conversation
Contributor
Author
|
Ok, this is just failing on Node.js 12 like the master branch. |
DeviaVir
approved these changes
Nov 30, 2019
Collaborator
DeviaVir
left a comment
DeviaVir
left a comment
There was a problem hiding this comment.
Indeed, code itself looks fine.
Approving, but will investigate what's up with node12
Collaborator
nodejs 12 fixes for rebase
…o add-tags * 'add-tags' of https://github.com/checkly/node-lambda: fixes return value and associated test when no tags are given adds tagging on new and updated functions
Contributor
Author
|
@DeviaVir Okido, looks like all checks are green! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature enables the user to add tags. I'm using the flag
-A, --tagswith key value pairs separated by=and,, e.g.-A tag1=value1,tag2=value2.Tags are automatically added on newly created functions; it's just another parameter in the params object. For updating functions, you need to first list the current tags, remove them and create the new ones. This is done in the newly created
_updateTags()function in the main code.