Use ci instead of install when installing packages#502
Use ci instead of install when installing packages#502DeviaVir merged 12 commits intomotdotla:masterfrom G-Rath:use-npm-ci-for-installing
ci instead of install when installing packages#502Conversation
|
Just realised pretty sure this'll fail in production b/c it requires the Actually, I'll update it to do a check for that, and use |
|
@DeviaVir finally got it passing 😂 I'd be happy to contribute more in my spare time if you'd like some help. I also think there could be value in converting to TypeScript, if that's something you'd be interested in :) The next immediate thing I'm looking into is adding wsl support via |
DeviaVir
left a comment
DeviaVir
left a comment
There was a problem hiding this comment.
LGTM, thanks for contributing- contributions are always welcome!
|
@DeviaVir cheers! I'm happy to contribute, but w/ something as big as moving to TS, I prefer knowing if it's something that maintainers are interested in before starting, since it's a very large change. I also think there might be gain in switching to jest for testing, just b/c I feel like it doesn't suffer from the same problems that mocha seems to (at least, problems that I've had running the tests in Windows & WSL). |
2 participants
npm ciinstalls the version of packages solely based on what's in thepackage-lock.json, making it faster since it doesn't need to resolve the versions of packages, and also ensures it installs the same package version every time.