Skip to content

Feature/context file#40

Closed
duckworth wants to merge 7 commits intomotdotla:masterfrom
duckworth:feature/contextFile
Closed

Feature/context file#40
duckworth wants to merge 7 commits intomotdotla:masterfrom
duckworth:feature/contextFile

Conversation

@duckworth
Copy link
Contributor

Adds a default empty context.json file which can be used to add additional mock data to the context object passed in to the lambda function for the run command. Adds a -x --contextFile param to override the contextFile used.

@ubiquitousthey
Copy link

This is great thing to add

@motdotla
Copy link
Owner

Thanks for this @duckworth. I'll take a look at this, this weekend.

@DeviaVir
Copy link
Collaborator

DeviaVir commented Apr 8, 2016

@duckworth I realize there is no .editorconfig attached to this project yet, but I'd appreciate it if you could update your changes to have the indenting as it was (2 spaces). It makes it also a lot harder to read your changes!

@DeviaVir
Copy link
Collaborator

ping @duckworth, do you still wish to own these changes?

@duckworth
Copy link
Contributor Author

ok, the formatting should be resolved.

@DeviaVir
Copy link
Collaborator

@duckworth thanks! I agree with the changes, unfortunately your branch is not mergeable due to changes upstream on master creating conflicts. Could you resolve that?

package.json Outdated
{
"name": "node-lambda",
"version": "0.7.1",
"version": "0.7.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to bump this up with #53 so there's no need for this change here.

@duckworth
Copy link
Contributor Author

Should I switch to use -c ? I didn't use that originally as that was already used on the deploy command. It appears that has been removed.

deploy -c, --mode [event] Lambda Mode

@DeviaVir
Copy link
Collaborator

@duckworth I removed my original comment after noticing that the PR I referenced used a different run command on conjunction with the -x so that can be ignored!

@DeviaVir
Copy link
Collaborator

@duckworth let me know if you need any help making your branch compatible (mergeable) with the current upstream/master.

@DeviaVir DeviaVir mentioned this pull request Apr 18, 2016
@DeviaVir
Copy link
Collaborator

Deprecated by #82

@DeviaVir DeviaVir closed this Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants