Support for Riak 2.0. Ability to use special indices $bucket, $key. Ability to provide max_results and continuation in db.query and get continuation back. #225

mogadanez · 2014-11-20T10:28:27Z

No description provided.

…results and continuation params

… of Object[Object], because buffer is often looks like: { phase: 0 error: "[{<<"lineno">>,466},{<<"message">>,<<"SyntaxError: syntax error">>},{<<"source">... (length: 92)" input: "{ok,{r_object,<<"users">>,<<"b1f0e0b64f8143a6a45977db8e29ff89">>,[{r_content,{di... (length: 515)" }

either we use asi or we don't mixing is bad

Since just dumping data in Riak without ever cleaning up is not nice I added a cleanup for all writen keys in the tests. This should also make sure that we don't have dependend tests Also commeted out search tests relying in pre solar functionaliy

this should only return the keys added (4) since we clean the bucket between tests

environment is set on Travis

only expect keys this tests explicitly saves

otherwise riak.conf will be ignored due to a present app.config

locally 1 sec is more than enough wait for indexes to propagate but on travis this seems to not be the case let's see...

Riak 2.0 basic support

Quentin01 · 2014-11-25T13:40:05Z

Your build don't pass with Travis CI

Quentin01 · 2014-11-25T13:45:26Z

Oops, I haven't seen your previous comment.
You may need to wait Riak for the service to start.

mogadanez · 2014-11-27T13:14:05Z

It passed now.
Actually some tests is very unstable and failing time to time even locally due some timings
But problems is in test not library.

Quentin01 · 2014-11-27T13:23:50Z

It's dirty to use many setTimeout. Can you use another solution or look at why it is mandatory to use setTimeout?

PS : Maybe a riak-admin wait-for-service?

Quentin01 · 2014-11-27T13:25:30Z

test/2.0-specific/http-yokozuna-client-test.js

On this test, and many others, you are not in agreement with the PR #201 which we have merged into master

mogadanez · 2014-11-27T14:44:46Z

Its come to our repository from https://github.com/sideshowcoder/riak-js

SetTimeouts is really hack. But for now I don't know better alternative.
Inside test it is not wait for service. But wait for index propagation, and data indexed. Since it is async operation
metacommunications@0ac9d6c
http://lists.basho.com/pipermail/riak-users_lists.basho.com/2014-November/016198.html

Probably it can be extracted from test to setup required test schema in install_riak.sh script.

Quentin01 · 2014-11-27T15:22:21Z

OK, so can you make a more proper code by using async module or another async library?
#225 (diff)

mogadanez · 2014-11-27T15:50:57Z

Yes, but probably only on weekend

On Thu, Nov 27, 2014 at 6:22 PM, Quentin Buathier notifications@github.com
wrote:

OK, so can you make a more proper code by using async module or another
async library ?

—
Reply to this email directly or view it on GitHub
#225 (comment).

Quentin01 · 2014-12-05T11:18:40Z

Any news for the updating of the tests ? Or for that comment : #225 (diff) ?

Conflicts: lib/http-client.js lib/meta.js test/http-client-test.js

…fter first one

mogadanez · 2015-04-08T11:14:48Z

Sorry for delay, test updated and test client now used.

mogadanez · 2015-04-14T09:30:41Z

ping

mogadanez · 2015-04-28T12:09:33Z

BTW, official node library is in active development
https://github.com/basho/riak-nodejs-client
probably good alternative

zowers · 2015-05-15T17:29:30Z

any eta on when somebody can merge this?

Quentin01 · 2015-05-18T15:29:54Z

This PR looks good. So, I merge it now. But I think we must do some refactor later on some things.
And sorry for the long time without answers :S

Support for Riak 2.0. Ability to use special indices $bucket, $key. Ability to provide max_results and continuation in db.query and get continuation back.

Alexander Popov and others added 30 commits September 4, 2013 18:03

fix for mostlyserious#180 - allow use in query. Also support for max_…

18b419b

…results and continuation params

fix for mostlyserious#180 - allow use /start/end index

08385df

tests for special indexes , . test for max_results and continuation

5e2c3cf

added .jshintrc to keep a certain coding style

22e8c8b

fix missing semicolons

8e50767

either we use asi or we don't mixing is bad

missing ;

bd9d006

some style fixes

35ceeff

Merge branch 'fix-repositories-to-repository' into riak-2.0

02119f1

Merge branch 'reading-2ii-to-meta' into riak-2.0

1785296

remove the luwak tests

a8bb95c

move the 1.4 specific tests to their own directory

4b7d486

prepare version specific search tests

6b8c0d1

first basic search via yokozuna passing

63a1214

Add matrix entry for Riak 2.0.0pre5.

c690219

Remove master exclusion for now.

b6c47fd

Escape if clause.

eb18bd9

Merge branch 'master' into mm-riak-2.0

60ae860

fix test for protocol buffer key fetch

95b64d4

this should only return the keys added (4) since we clean the bucket between tests

it's enough to clean after all tests are done

207dfe1

Merge branch 'mm-riak-2.0' into riak-2.0

f2b8b7b

run 2.0 or 1.4 tests depending on the environment

f3c51ea

environment is set on Travis

make sure yokozuna is enabled for 2.0

1cdfc74

make sure the key stream tests does not interfer

b68301b

only expect keys this tests explicitly saves

make sure the config files from riak are removed

73ed95b

otherwise riak.conf will be ignored due to a present app.config

wait for yokozuna index to propagate

0ac9d6c

is the travis vm that much slower?

7683743

locally 1 sec is more than enough wait for indexes to propagate but on travis this seems to not be the case let's see...

fix error handling

7f0efbd

Merge pull request #1 from sideshowcoder/riak-2.0

b4b19c9

Riak 2.0 basic support

Alexander Popov added 9 commits November 27, 2014 10:06

curl pre-test connectivity

1edeb03

.

89c0406

more diagnostics

f597f7c

more diagnostics

224e79b

update riak install procedure

2c4a7e7

update shuoldJS calls to latest version

9f7a7d3

fix misspeling

2f09be7

yz_index => search_index

5ad58ca

add more diagnostic on failing test

45f049c

Quentin01 reviewed Nov 27, 2014
View reviewed changes

Alexander Popov added 5 commits January 22, 2015 11:32

include indexes in response meta

5583ad0

rewrite test with bluebird

2f9baee

Merge branch 'master' of git://github.com/mostlyserious/riak-js

60b38c1

Conflicts: lib/http-client.js lib/meta.js test/http-client-test.js

use http-test-client to be in trend of mostlyserious#201

a3afd17

do not recreate search schema if not changed, much faster test runs a…

fe8ec16

…fter first one

Quentin01 added a commit that referenced this pull request May 18, 2015

Merge pull request #225 from metacommunications/master

a033839

Support for Riak 2.0. Ability to use special indices $bucket, $key. Ability to provide max_results and continuation in db.query and get continuation back.

Quentin01 merged commit a033839 into mostlyserious:master May 18, 2015

Support for Riak 2.0. Ability to use special indices $bucket, $key. Ability to provide max_results and continuation in db.query and get continuation back. #225

Support for Riak 2.0. Ability to use special indices $bucket, $key. Ability to provide max_results and continuation in db.query and get continuation back. #225

Uh oh!

Conversation

mogadanez commented Nov 20, 2014

Uh oh!

Quentin01 commented Nov 25, 2014

Uh oh!

Quentin01 commented Nov 25, 2014

Uh oh!

mogadanez commented Nov 27, 2014

Uh oh!

Quentin01 commented Nov 27, 2014

Uh oh!

Quentin01 Nov 27, 2014

Choose a reason for hiding this comment

Uh oh!

mogadanez commented Nov 27, 2014

Uh oh!

Quentin01 commented Nov 27, 2014

Uh oh!

mogadanez commented Nov 27, 2014

Uh oh!

Quentin01 commented Dec 5, 2014

Uh oh!

mogadanez commented Apr 8, 2015

Uh oh!

mogadanez commented Apr 14, 2015

Uh oh!

mogadanez commented Apr 28, 2015

Uh oh!

zowers commented May 15, 2015

Uh oh!

Quentin01 commented May 18, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants