Skip to content

refactor(morpho-sdk): Extract morpho-sdk bundler action encoding#669

Open
Rubilmax wants to merge 13 commits into
extract-public-reallocationfrom
drop-bundler-sdk-viem
Open

refactor(morpho-sdk): Extract morpho-sdk bundler action encoding#669
Rubilmax wants to merge 13 commits into
extract-public-reallocationfrom
drop-bundler-sdk-viem

Conversation

@Rubilmax
Copy link
Copy Markdown
Collaborator

Summary

  • Extract the Bundler3 action encoding surface required by morpho-sdk into packages/morpho-sdk.
  • Remove @morpho-org/bundler-sdk-viem from morpho-sdk dependencies and lockfile importer data.
  • Keep migration-sdk-viem unchanged, including its existing bundler-sdk-viem wiring, because it is slated for deprecation.
  • Move the new BundlerErrors namespace into packages/morpho-sdk/src/types/error.ts and re-export it from the local bundler action surface.

Validation

  • pnpm --filter @morpho-org/morpho-sdk exec tsc --noEmit -p tsconfig.build.esm.json
  • pnpm --filter @morpho-org/morpho-sdk exec tsc --noEmit -p tsconfig.build.cjs.json
  • pnpm exec vitest --root . --project morpho-sdk packages/morpho-sdk/src/actions/bundler.test.ts --run
  • pnpm lint
  • git diff --check

@Rubilmax Rubilmax changed the title [codex] Extract morpho-sdk bundler action encoding refactor(morpho-sdk): Extract morpho-sdk bundler action encoding May 13, 2026
@Rubilmax Rubilmax force-pushed the extract-public-reallocation branch from 5eb6445 to fd7e814 Compare May 13, 2026 14:28
@Rubilmax Rubilmax force-pushed the drop-bundler-sdk-viem branch 2 times, most recently from 08b3d89 to 05e19d9 Compare May 13, 2026 14:34
@Rubilmax Rubilmax force-pushed the drop-bundler-sdk-viem branch from 05e19d9 to 71e4a01 Compare May 13, 2026 15:19
Copy link
Copy Markdown
Collaborator Author

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rubilmax Rubilmax marked this pull request as ready for review May 13, 2026 15:21
@Rubilmax Rubilmax self-assigned this May 13, 2026
@Rubilmax
Copy link
Copy Markdown
Collaborator Author

@codex

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@Rubilmax Rubilmax force-pushed the extract-public-reallocation branch from fd7e814 to b5d0ec4 Compare May 13, 2026 17:24
@Rubilmax Rubilmax requested a review from a team as a code owner May 13, 2026 17:24
@Foulks-Plb Foulks-Plb self-requested a review May 15, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant