This repository was archived by the owner on Feb 4, 2024. It is now read-only.
Fixes deprecation warnings #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdlrobson
commented
Jun 1, 2022
jdlrobson
commented
- Module mediawiki.skinning.content.externallinks is removed in 1.39
- Adds version requirement
- Removes output of head tag in 1.39
- Module mediawiki.skinning.content.externallinks is removed in 1.39 - Adds version requirement - Removes output of head tag in 1.39
morags
reviewed
Jun 2, 2022
Owner
morags
left a comment
morags
left a comment
There was a problem hiding this comment.
Hey Jon, thanks for the contribution. Are we duplicating the entire header from main.mustache toskin.mustache?
Accidentally added
Contributor
Author
|
My mistake! No we are just removing the body tag. Confusingly headelement also contains a body element so the skin was outputting 2 opening body tags before. |
Contributor
Author
|
Thanks for keeping this skin up to date! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.