test(NODE-5317): use new evergreen scripts#3669
Merged
Merged
Conversation
durran
force-pushed
the
DRIVERS-2328
branch
5 times, most recently
from
a72240e to
4c280f3
Compare
durran
changed the title
durran
commented
May 22, 2023
| ${MONGODB_BINARIES}/mongo --nodb setup.js aws_e2e_ecs.js | ||
| export MONGODB_BINARIES="${MONGODB_BINARIES}"; | ||
| export PROJECT_DIRECTORY=$PROJECT_DIRECTORY; | ||
| python aws_tester.py ecs |
Contributor
Author
There was a problem hiding this comment.
This will fail our first AWS test that checks that no auth credentials in the URI will fail. It actually connects successfully because the mongod is started without enforcing access control.
durran
changed the title
Comment on lines
+824
to
+825
| # fix issue with `TestData` in SERVER-46340 | ||
| sed -i '1s+^+TestData = {};\n+' $AUTH_AWS_DIR/lib/ecs_hosted_test.js | ||
| # sed -i '1s+^+TestData = {};\n+' $AUTH_AWS_DIR/lib/ecs_hosted_test.js |
Contributor
There was a problem hiding this comment.
Tests are passing with this code commented out - should this be removed entirely?
Contributor
|
evergreen retry |
baileympearson
approved these changes
May 31, 2023
Contributor
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
failing tests are unrelated to the changes in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the driver to use the new AWS auth Evergreen scripts.
What is changing?
Updates the driver to use mongodb-labs/drivers-evergreen-tools#306
NOTE The failure scenario is removed from the AWS tests as the servers that are set up in the scripts have access control disabled, which means connecting without auth will succeed, rendering that test as a failure. The auth prose tests require no failure case, so this is now removed.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
DRIVERS-2328
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript