docs: add google tag#331
Conversation
|
Works fine on 2.6: |
doc/conf.py
Outdated
| # General information about the project. | ||
| project = u'PyMongo' | ||
| copyright = u'2008 - 2015, MongoDB, Inc.' | ||
| copyright = u'2008-{0}'.format(datetime.date.today().year) |
There was a problem hiding this comment.
Clever. Can you add back the ", MongoDB, Inc."? Overwise the bottom of the page just says "© Copyright 2008-2017. Created using Sphinx 1.4.5."
|
|
||
| {%- block extrahead %} | ||
|
|
||
| {% if theme_googletag %} |
There was a problem hiding this comment.
Isn't theme_googletag always false? What's the point of adding this if it's never included?
There was a problem hiding this comment.
I talked to Bernie and he pointed out that we want the default to be false. It doesn't make sense for local docs builds to include it.
We'll only enable this for the production builds on http://api.mongodb.com/python.
There was a problem hiding this comment.
When we build from apidocs, we'll flipt to true. This way, people can clone this repo and it won't be on whereas when we build for api.mongodb.com, it will be on and we can track.
|
FYI -- @ShaneHarvey / @behackett -- I updated the copyright to be consistent with the docs (the docs' copyright blurb was what Todd the legal guy had asked us to do last year) -- I suppressed the Sphinx build blurb, but can put it back if you all want it in there. |
|
@ShaneHarvey / @behackett -- no hurry on my end. Just a note to make sure you all haven't forgotten about this pull request. If you haven't, feel free to ignore my comment :D |
|
Thanks for the reminder! |
2 participants
Need to check python 2.6 for the date