Skip to content

[stdlib] Add codepoint slicing#6552

Open
martinvuyk wants to merge 1 commit into
modular:mainfrom
martinvuyk:add-codepoint-slicing
Open

[stdlib] Add codepoint slicing#6552
martinvuyk wants to merge 1 commit into
modular:mainfrom
martinvuyk:add-codepoint-slicing

Conversation

@martinvuyk
Copy link
Copy Markdown
Contributor

Add codepoint slicing

@martinvuyk martinvuyk requested a review from a team as a code owner May 15, 2026 20:30
@github-actions github-actions Bot added mojo-stdlib Tag for issues related to standard library waiting-on-review labels May 15, 2026
@martinvuyk martinvuyk force-pushed the add-codepoint-slicing branch from 058a27d to 26f6381 Compare May 15, 2026 20:32
Copy link
Copy Markdown
Contributor

@barcharcraz barcharcraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either make the "off the end" slicing behavior consistent with everything else or document the different behavior here.

Comment thread mojo/stdlib/std/collections/string/string_slice.mojo Outdated
Comment thread mojo/stdlib/test/collections/string/test_string_slice.mojo
@barcharcraz
Copy link
Copy Markdown
Contributor

This also needs a changelog entry

Signed-off-by: martinvuyk <martin.vuyklop@gmail.com>
@martinvuyk martinvuyk force-pushed the add-codepoint-slicing branch from 26f6381 to 3b1e94c Compare May 16, 2026 00:35
@martinvuyk martinvuyk requested a review from barcharcraz May 16, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mojo-docs mojo-stdlib Tag for issues related to standard library waiting-on-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants