Reproducible build - #189
Conversation
|
Supersedes #177 |
|
@aalmiray any blocker before merging and releasing? |
|
@hboutemy waiting for a review from @gunnarmorling as the changes posted are more extensive that I thought |
gunnarmorling
left a comment
gunnarmorling
left a comment
There was a problem hiding this comment.
LGTM. One question inline, but it's not a blocker. Feel free to merge one way or the other. Thanks!
| description = "Path to the module-info.java descriptor", | ||
| converter = PathConverter.class | ||
| ) | ||
| @Parameter(names = "--module-info", required = true, description = "Path to the module-info.java descriptor", converter = PathConverter.class) |
There was a problem hiding this comment.
Is this actually more readable? Not that I'm interested in having a formatting style discussion, but could we configure it so it doesn't join wrapped lines? At least there's such an option in the Eclipse formatter. If it's not doable here for some reason, let's go with the proposed change.
There was a problem hiding this comment.
I took the formatting configuration from the moditect-org-parent project
There was a problem hiding this comment.
Ok, can we then perhaps add the "don't join wrapped lines" config there?
There was a problem hiding this comment.
As far as I can tell it's already there
<setting id="org.eclipse.jdt.core.formatter.join_wrapped_lines" value="false"/>
|
@aalmiray time for merge and release? |
|
FYI: i just checked RB for this release and all went well!!! the plugin itself is reproducible |
3 participants
Updates parent pom to make build reproducible.
As a side effect the code-formatter was also updated hence why so many source files have also been updated.