Repository navigation
fix(shared): stop referencing the DOM-only HeadersInit in normalizeHeaders - #3069
Open
ziadantar90 wants to merge 1 commit into
Open
ziadantar90 wants to merge 1 commit into
ziadantar90 wants to merge 1 commit into
Conversation
…aders HeadersInit is a DOM lib type alias, so Node-only projects without the DOM lib fail with TS2304 when skipLibCheck is off. RequestInit['headers'] is the same type and is available from @types/node. Fixes modelcontextprotocol#2568 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018dKyMg1Frb5EXMwBaEw51t
🦋 Changeset detectedLatest commit: a8f0179 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2568.
normalizeHeaderstook a bareHeadersInit, which is a DOM lib type alias. Node-only projects without theDOMlib and withskipLibCheck: falsefail on the publishedtransport.d.tswithTS2304: Cannot find name 'HeadersInit'.The parameter is now
RequestInit['headers'] | undefined. That's the same type, andRequestInitis available from@types/node. Runtime behavior is unchanged.I left the two local
HeadersInit & Record<string, string>variables insse.tsandstreamableHttp.tsalone, since they don't show up in the published types.Added a changeset and tests for
normalizeHeaders(undefined,Headers, tuple array, plain object).vitestontest/shared/transport.test.ts,tsc,eslintandprettierpass locally.