Merged
Conversation
bhosmer-ant
previously approved these changes
Jun 17, 2025
Contributor
bhosmer-ant
left a comment
There was a problem hiding this comment.
Inline comment re Content/ContentBlock, but your call
src/mcp/types.py
Outdated
| ContentBlock = TextContent | ImageContent | AudioContent | ResourceLink | EmbeddedResource | ||
| """A content block that can be used in prompts and tool results.""" | ||
|
|
||
| Content = ContentBlock |
Contributor
There was a problem hiding this comment.
Assuming this is to reduce blast radius for the PR, but if so, should we maybe leave it named Content and then do the Content -> ContentBlock change in a followup, rather than having both names floating around?
Contributor
Author
There was a problem hiding this comment.
need to add deprecated!
|
|
||
| role: Role | ||
| content: Content | ||
| content: ContentBlock |
| """The server's response to a tool call.""" | ||
|
|
||
| content: list[Content] | ||
| content: list[ContentBlock] |
ihrpr
commented
Jun 17, 2025
| """A content block that can be used in prompts and tool results.""" | ||
|
|
||
| Content: TypeAlias = ContentBlock | ||
| # """DEPRECATED: Content is deprecated, you should use ContentBlock directly.""" |
Contributor
Author
There was a problem hiding this comment.
leaving content just in case someone uses it from SDK and not to break them
Contributor
|
test failure looks like a linux flake? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details: modelcontextprotocol/modelcontextprotocol#603
Closes #944