fix: handle None required_scopes in validate_scope#2368
Open
IgnazioDS wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: handle None required_scopes in validate_scope#2368IgnazioDS wants to merge 1 commit intomodelcontextprotocol:mainfrom
IgnazioDS wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
When required_scopes is None (meaning no restrictions), skip validation entirely instead of treating it as an empty set of allowed scopes which rejects all client-requested scopes. Github-Issue: modelcontextprotocol#2216
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_scope()whenself.scopeisNoneNonemeans "no scope restrictions" per the OAuth spec, so all client-requested scopes should be acceptedNonewas treated as an empty allowed set, rejecting all scopes withInvalidScopeErrorProblem
When an MCP server does not specify required scopes (
None), clients cannot authenticate because all requested scopes are rejected. See #2216.Test plan
validate_scope("read write admin")accepts all scopes whenscope=Nonevalidate_scope("read write")still rejects unauthorized scopes whenscope="read"validate_scope(None)returnsNonevalidate_scope("read write")accepts whenscope="read write"Fixes #2216