Introduce Initialization options that are passed to ServerSession#16
Introduce Initialization options that are passed to ServerSession#16
Conversation
mcp_python/server/session.py
Outdated
There was a problem hiding this comment.
Can we use a Pydantic model here for consistency?
mcp_python/server/session.py
Outdated
There was a problem hiding this comment.
Can we infer this by default, instead of always requiring it to be passed in?
There was a problem hiding this comment.
I rather be explicit about it for now. I'll keep it in mind however.
mcp_python/server/__init__.py
Outdated
There was a problem hiding this comment.
Can we add a test for this?
mcp_python/server/__init__.py
Outdated
There was a problem hiding this comment.
It seems like this code would be simpler if this is just passed in directly to the ServerCapabilities constructor. I guess the point is to do the None filtering, though—I wish we could figure out how to get Pydantic to do that
There was a problem hiding this comment.
Okay I talked with Claude about this. There might be ways do this with pydantic, but we both prefer the more explicit approach. I added a helper function so people can pass it via app.create_initialization_option(). If you feel strongly about it, i am happy to change it.
dsp-ant
force-pushed
the
davidsp/init-options
branch
2 times, most recently
from
a1afc21 to
3b5b4a4
Compare
We need a way for servers to pass initialization options to the session. This is the beginning of this.
dsp-ant
force-pushed
the
davidsp/init-options
branch
from
3b5b4a4 to
cc342a0
Compare
feat(mcp): support discord approvals
2 participants
Depends on:
There is currently no way for server implementations to pass capabilities, server name and server version to the protocol. We now introduce an
InitializationOptionobject that can be passed. Users of this are free to use the newget_capabilitiesto fill capabilities based on the defined handlers. This will allow patterns such asThis is mostly an RFC. I am not sold on the specific approach but want to get something going so that we can correctly negotiate capabilities between our Zed implementation of the protocol and Python servers.