Add constructor for McpError to allow setting error field#116
Closed
allenporter wants to merge 1 commit into
Closed
Add constructor for McpError to allow setting error field#116allenporter wants to merge 1 commit into
error field#116allenporter wants to merge 1 commit into
Conversation
dsp-ant
pushed a commit
that referenced
this pull request
Jan 2, 2025
Backport of #116 by @allenporter to v1.1.x branch. Fixes an issue where exception handling code fails with AttributeError when accessing the error field of McpError.
Member
|
This was merged as b89cabc. I tried to update your branch to be based on v1.1.x so we can keep the PR workflow going, but i got permission denied. So I'll close this ,but it's actually merged and attributed to you! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix an issue where exception handling code fails with
AttributeError: 'McpError' object has no attribute 'error'.The current callers of
McpErrorseem to assume that it has a constructor that accepts anerror_databut currently these get passed to the parent as the error message args (e.g. as if it were a pydantic object). This correctly sets the error code argument and sets the message string for the parent class.How Has This Been Tested?
Tested manually running an
sse_clientconnected to a service that returns errors for unsupported methods when called.Breaking Changes
Types of changes
Checklist
Additional context