fix: deduplicate title definition in tools #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
force-pushed
the
connor4312/dedupe-tool-title
branch
from
5dfd34a to
3820b42
Compare
Member
|
We are describing the precedence here: https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/2025-06-18/schema.ts#L283, since we didn't want to break backwards compatibility. I'll leave this open, since adding this likely depends if the next spec version is breaking backwards compatibility or not. If thats the case we might be okay with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Following #663, there are now two ways for a Tool to define a title, as
Tool.titlewhich is now receives thoughBaseMetdata, and also inTool.anotations.title. I believe this change was made in error as it's not clear to clients which they should use.How Has This Been Tested?
Not tested
Breaking Changes
Yes, this is a breaking change by removal of the old property.
Types of changes
Checklist
Additional context