Revise sampling specification to define all valid request and response fields #531
+63
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalstate
reviewed
May 15, 2025
LucaButBoring
force-pushed
the
spec/sampling-includecontext
branch
from
f54bdf9 to
93603e9
Compare
Contributor
Author
|
@dsp-ant or @cliffhall, maybe? This doesn't make any schema changes to the spec, it just fills in missing documentation. |
evalstate
reviewed
Jul 16, 2025
evalstate
reviewed
Jul 16, 2025
Contributor
Author
|
Updated, re-requested reviews. |
cliffhall
requested changes
Jul 16, 2025
3 tasks
LucaButBoring
force-pushed
the
spec/sampling-includecontext
branch
from
6316ff7 to
9f681bc
Compare
Co-authored-by: Cliff Hall <cliff@futurescale.com>
LucaButBoring
force-pushed
the
spec/sampling-includecontext
branch
from
2f31999 to
dc634be
Compare
Member
|
This is actually quite good but sampling now has changed. Is this worthwhile fixing up and merging? |
Contributor
Author
Contributor
|
@LucaButBoring do you have a sponsor for this yet? |
Contributor
Author
|
No, but is this SEP-worthy to begin with? It should simply be describing the current definitions of some undocumented sampling fields (if anyone disagrees, we may need to relax the phrasing in a few places). |
Contributor
|
This is a spec enhancement, but I will defer to @dsp-ant if he wants this broadly reviewed or just merged into the draft. Seems small enough of a change. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the sampling specification to explicitly define all request and response fields, so that implementers (and more importantly, MCP application developers) can better understand sampling holistically through its spec, rather than wholly relying on the schema alone.
Motivation and Context
See #503. This change improves the written specification by more accurately describing the current expected request and response behaviors of the server and client, respectively.
How Has This Been Tested?
N/A; validated spec website itself in Mintlify. This PR proposes no schema changes and no behavior changes compared to how clients and servers already behave.
Breaking Changes
None.
Types of changes
Checklist
Additional context
This PR is in flight alongside #198 and #522, and may need to be adjusted accordingly depending on the order in which these three PRs are merged.