-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Enforce parity between supported message types in tool results and sampling #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce parity between supported message types in tool results and sampling #522
Conversation
|
Hi @LucaButBoring -- it's probably worth considering this alongside: #198 |
79fb8c7 to
5789ac9
Compare
Looks like that's close to getting merged, any idea who to tag for more traction on that (also I think yours needs to be moved to the |
|
Yep, needs an update - I'll pick that up tomorrow and give it a nudge. |
5789ac9 to
11ac444
Compare
ffffd1b to
7e89e60
Compare
|
Rebased and added a section to the spec on resource links. |
6f22167 to
77bcdee
Compare
|
hi are there any blockers for this feature? |
This change would need an accompanying SEP. (This PR and the related issue were both submitted before the SEP process was established.) I think it would suffice to update the original issue to match the SEP format. |
|
I am closing this for no. If we feel this should exists, then let's create a SEP. |
Updates sampling to support resources as messages, but also to reuse the same supported message type as tool calls to enforce parity between tools and sampling.
Motivation and Context
See #503. This change improves the cohesiveness of sampling in the protocol by making sure that sampling does not lag behind tool calls in terms of what data can be handled.
How Has This Been Tested?
Breaking Changes
None from a spec perspective - if SDKs implement this as a tagged union (as the TS SDK does) and consumers assume exhaustive case handling means all types have been handled, then consumers may need to update their code to support this.
Types of changes
Checklist
Additional context