fix(SEP-2322): Explicitly support extending ResultType#2773
Merged
CaitieM20 merged 4 commits intoMay 28, 2026
Merged
Conversation
Member
|
LGTM - seems the sensible solution to extensibility here. |
CaitieM20
reviewed
May 27, 2026
CaitieM20
reviewed
May 27, 2026
CaitieM20
requested changes
May 27, 2026
CaitieM20
left a comment
CaitieM20
left a comment
Contributor
There was a problem hiding this comment.
requested some spec wording changes for clarity
Co-authored-by: Caitie McCaffrey <caitiem20@github.com>
LucaButBoring
force-pushed
the
fix/resultType-extensibility
branch
from
532952e to
93c027f
Compare
Contributor
Author
|
Updated and rebased |
Contributor
|
Looks good to me! |
CaitieM20
approved these changes
May 28, 2026
LucaButBoring
added a commit
to modelcontextprotocol/ext-tasks
that referenced
this pull request
May 28, 2026
LucaButBoring
added a commit
to modelcontextprotocol/agents-wg
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly declares support for extending the
ResultTypetype so that extensions can extend it with their own extended set of extended values.ResultTypevalues unrecognized by the client are considered invalid protocol responses (fail-closed).This modifies #2322 and #2663.
Motivation and Context
This change makes it clear to SDK maintainers that the
resultTypefield may be extended by extensions. This is particularly relevant for the Tasks extension.In particular, we want to avoid a situation where an extension (like Tasks) requires extending
resultTypebut an SDK has implemented that discriminated union in a way that makes extensions impossible without introducing breaking changes to SDK consumers.How Has This Been Tested?
N/A
Breaking Changes
N/A
Types of changes
Checklist
Additional context