Pagination#21
Merged
Merged
Conversation
ashwin-ant
approved these changes
Oct 7, 2024
jspahrsummers
pushed a commit
that referenced
this pull request
Mar 12, 2025
Python version of the concepts pages
|
Say I made an API call which is paginated at my server end upon receiving the tool/call. Does it support pagination? |
localden
added a commit
that referenced
this pull request
Apr 9, 2026
CodeQL flagged execSync with interpolated file paths as CWE-78/CWE-88 shell injection. The paths are derived from __dirname and SEP filenames, so direct exploitability requires commit access — but paths with spaces or shell metacharacters would still break the command. Replaced execSync template-string interpolation with execFileSync and an args array. Paths are passed as separate process arguments, never touching a shell. The win32 npx.cmd resolution keeps it cross-platform. Fixed both occurrences (lines 395 and 435 had the identical pattern; the alert only flagged 435). Fixes https://github.com/modelcontextprotocol/modelcontextprotocol/security/code-scanning/21 🏠 Remote-Dev: homespace
mcp-commander Bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
…) (#2546) CodeQL flagged execSync with interpolated file paths as CWE-78/CWE-88 shell injection. The paths are derived from __dirname and SEP filenames, so direct exploitability requires commit access — but paths with spaces or shell metacharacters would still break the command. Replaced execSync template-string interpolation with execFileSync and an args array. Paths are passed as separate process arguments, never touching a shell. The win32 npx.cmd resolution keeps it cross-platform. Fixed both occurrences (lines 395 and 435 had the identical pattern; the alert only flagged 435). Fixes https://github.com/modelcontextprotocol/modelcontextprotocol/security/code-scanning/21 🏠 Remote-Dev: homespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional cursor-based pagination to all
list-type requests.I've also split out the listing of resources and resource templates, which makes the interfaces simpler. Although this is a breaking change, I don't think anything actually exists that depends on this right now.
In keeping with our MCP design philosophy, pagination logic is entirely up to the server (including whether it exists at all): the server returns however many results it wants to, and an optional cursor if the client can request more.
Resolves #6.