-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Mention Tool.execution in tools.mdx #1929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Mention Tool.execution in tools.mdx #1929
Conversation
He-Pin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| ] | ||
| ], | ||
| "execution": { | ||
| "taskSupport": "optional" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be forbidden for it's the default behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had considered that, but there wouldn't be much value there over not including it at all, so I figured I'd make it optional to show a deviation from the default here.
| ] | ||
| ], | ||
| "execution": { | ||
| "taskSupport": "optional" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be forbidden for it's the default behavior
|
My only concern here is that this modifies the existing stable spec beyond the draft, but given thtat this is a documentation gap, it's less of an issue. @dsp-ant - thoughts? |
The 11/25 spec release added the
Tool.executionfield, but neglected to mention it anywhere in the actual tools spec. This adds that to both the 11/25 and draft spec pages, as it does not imply any behavioral changes.Motivation and Context
Communicates that
Tool.executionis a field that exists.How Has This Been Tested?
N/A
Breaking Changes
None
Types of changes
Checklist
Additional context