Skip to content

Remove deprecated taskId from cancellation notification #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
localden merged 4 commits into from
Nov 20, 2025
Merged

Remove deprecated taskId from cancellation notification #1833

localden merged 4 commits into from
Nov 20, 2025

Conversation

@LucaButBoring
Copy link
Contributor

@LucaButBoring LucaButBoring commented Nov 18, 2025

During #1732, task cancellation was moved from notifications/cancelled to a new tasks/cancel request. The taskId added to notifications/cancelled was incorrectly immediately deprecated instead of removed.

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@LucaButBoring LucaButBoring requested a review from a team as a code owner November 18, 2025 17:47
@He-Pin
Copy link
Contributor

He-Pin commented Nov 18, 2025

lgtm, nice clean up.

@localden localden added the rc-high-priority Related to an upcoming specification release and needs to be addressed with a high priority. label Nov 20, 2025
@localden localden moved this to In review in 2025-11-25 Implementation Nov 20, 2025
@localden localden merged commit 22fb4bd into modelcontextprotocol:main Nov 20, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in 2025-11-25 Implementation Nov 20, 2025
This was referenced Nov 21, 2025
Open
Open
Open
Closed
Closed
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@000-000-000-000-000 000-000-000-000-000 000-000-000-000-000 approved these changes

Assignees

@000-000-000-000-000 000-000-000-000-000

Labels

rc-high-priority Related to an upcoming specification release and needs to be addressed with a high priority.

Projects

2025-11-25 Implementation
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LucaButBoring @He-Pin @000-000-000-000-000 @localden @felixweinberger