-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Elicitation: clarify clickable URL language #1811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elicitation: clarify clickable URL language #1811
Conversation
| 1. **MUST NOT** include plain text sensitive information about the end-user, including credentials, personal identifiable information, etc., in the URL sent to the client. | ||
| 1. **MUST NOT** provide a URL which is pre-authenticated to access a protected resource, as the URL could be used to impersonate the user by a malicious client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two MUSTs did not change substantively
| 1. **MUST NOT** include URLs in any message or schema fields as part of a form mode elicitation request. | ||
| 1. **MUST NOT** include URLs in any message or schema fields as part of an URL mode elicitation request, except for the `url` field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these two MUSTs in favor of a SHOULD
| 1. **SHOULD** use HTTPS URLs for non-development environments. | ||
| 1. **MUST NOT** include sensitive information about the end-user, including credentials, personal identifiable information, etc., in the URL sent to the client in a URL elicitation request. | ||
| 2. **MUST NOT** provide a URL which is pre-authenticated to access a protected resource, as the URL could be used to impersonate the user by a malicious client. | ||
| 3. **SHOULD NOT** include URLs intended to be clickable in any field of a form mode elicitation request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this SHOULD - still worth calling out IMO, but I think for conformance purposes it can be a SHOULD and doesn't need to be a failing case.
pcarleton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome lgtm
Motivation and Context
Fast-follow to #887 to address a spec language clarification discussed with @pcarleton.
How Has This Been Tested?
N/A
Breaking Changes
N/A
Types of changes
Checklist