Conversation
nickcoai
changed the title
pcarleton
left a comment
pcarleton
left a comment
There was a problem hiding this comment.
lgtm overall, unsure if the SEP States changes were intentional
| ### SEP States | ||
|
|
||
| SEPs can be one one of the following states | ||
| SEPs move through the following states, which are recorded in the SEP header: |
There was a problem hiding this comment.
did we mean to change the states?
There was a problem hiding this comment.
Not this much, took them from the README in the seps folder, will treat this one as canonical and update the latter.
There was a problem hiding this comment.
Actually, I'm not sure these make as much sense for granularity given the changelog of the SEP md file
Namely Proposal isn't relevant [the sponsor block records that], and Dormant I think is implied by the PR state?
| 3. Find a Core Maintainer or Maintainer to sponsor your proposal. Tag potential sponsors from [MAINTAINERS.md](https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/MAINTAINERS.md). Once someone agrees, record their handle in the `Sponsor` field. | ||
| 4. After the pull request number is known, rename the file to `seps/{PR-number}-{slug}.md` and update the title/header to `SEP-{PR-number}` along with `PR: #{PR-number}`. | ||
| 5. Work with your sponsor to iterate on the proposal. Sponsors move the SEP through `Draft → In-Review → Accepted → Final` by updating the `Status` field in the file and using matching pull request labels. | ||
| 6. Provide or link to a reference implementation before requesting `Final` status. The pull request containing the SEP should include links to any tracking issues or additional PRs needed to implement the change. |
There was a problem hiding this comment.
Is the SEP PR meant to be eventually merged into main? i.e., Will we keep the seps/ directory in git history?
If so, can the SEP PR also contain the necessary changes to the spec and documentation?
(I presume so, since that is what this SEP appears to be doing, but this item makes it sound like the SEP PR should link to an additional PR for the spec.)
There was a problem hiding this comment.
- After the pull request number is known, rename the file to
seps/{PR-number}-{slug}.mdand update the title/header toSEP-{PR-number}along withPR: #{PR-number}.
Isn't the PR: #{PR-number} redundant?
Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
|
closing in favor of #1850 |
5 participants
Adjust primary SEP process to be file-based.
Motivation and Context
We often want SEPs to accompany changes, and an issue is awkward for discussion and loses version history (and makes multiple-contributors difficult). Instead move to a markdown document for the change.
Types of changes
Checklist