Replace Assert.hasText() method with Utils.hasText() for reducing duplicate code - #71
Closed
codeboyzhou wants to merge 1 commit into
Closed
Replace Assert.hasText() method with Utils.hasText() for reducing duplicate code#71codeboyzhou wants to merge 1 commit into
codeboyzhou wants to merge 1 commit into
Conversation
Contributor
|
I don't think this change is necessary. The Assert and the Utils serve different purpose and both are valid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
Assert.hasText()method withUtils.hasText()for reducing duplicate code.Motivation and Context
There is already
Utils.hasText()method in theUtilsclass, and it's exactly the same asAssert.hasText().How Has This Been Tested?
Running tests with
./mvnw test(the related unit test is in my previous PR #70)Breaking Changes
No breaking changes
Types of changes
Checklist
Additional context
No additional context