Conversation
This works around the breaking change to BackgroundService in dotnet/runtime#116283 which launches ExecuteAsync using Task.Run
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves options validation from the ExecuteAsync method to the constructor in IdleTrackingBackgroundService to address a breaking change in .NET 10 where BackgroundService launches ExecuteAsync using Task.Run, potentially causing validation exceptions to be lost.
- Refactored IdleTrackingBackgroundService to use traditional constructor with field assignments instead of primary constructor
- Moved validation logic from ExecuteAsync to constructor to ensure early failure
- Removed conditional compilation directives that were skipping tests on .NET 10
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IdleTrackingBackgroundService.cs | Converted from primary constructor to traditional constructor with field assignments and moved validation logic |
| StreamableHttpServerConformanceTests.cs | Removed .NET 10 conditional compilation that was skipping validation tests |
Comments suppressed due to low confidence (1)
src/ModelContextProtocol.AspNetCore/IdleTrackingBackgroundService.cs:1
- The validation logic should validate the options before assigning them to fields. Move these validation calls to occur before the field assignments at lines 28-31 to fail fast if invalid options are provided.
using Microsoft.Extensions.Hosting;
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eiriktsarpalis
approved these changes
Oct 2, 2025
This was referenced Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around the breaking change to BackgroundService in dotnet/runtime#116283 which launches ExecuteAsync using Task.Run.
Fixes #823