Add comprehensive edge case tests for JSON-RPC payload shapes#1143
Merged
stephentoub merged 4 commits intomainfrom Jan 14, 2026
Merged
Add comprehensive edge case tests for JSON-RPC payload shapes#1143stephentoub merged 4 commits intomainfrom
stephentoub merged 4 commits intomainfrom
Conversation
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
stephentoub
reviewed
Jan 14, 2026
tests/ModelContextProtocol.Tests/Protocol/JsonRpcMessageConverterTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
auto-merge was automatically disabled
January 14, 2026 02:06
Head branch was pushed to by a user without write access
Copilot
AI
changed the title
[WIP] Add tests for various JSON-RPC payload shapes
Add comprehensive edge case tests for JSON-RPC payload shapes
Jan 14, 2026
eiriktsarpalis
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1138: adds tests validating behavior for less-common JSON-RPC payload shapes that may come from various implementations.
New test coverage (26 tests)
"error": nullwith result, bothresultanderrornulllong.MaxValueparamsbeforemethod,resultbeforeidExample
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.