Repository navigation
Conversation
The file-path pattern also matched decimals, versions, and addresses with no letter (0.52, 127.0.0.1) and dotted abbreviations (e.g, i.e), and the acronym pattern admitted ordinary words written in capitals for emphasis or as labels (NEVER, ONLY, NOTE, FIXED). On a real store these were among the most frequent stored entities, and entity edges linked memories that shared nothing but a decimal or an emphasis word. File-path matches now need a letter and a dot-separated segment longer than one character, and the acronym stoplist gains the emphasis words while leaving out words that double as technical names (HEAD, POST, PATH). Validated with make test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two filters in
ExtractEntities:0.52,127.0.0.1) and dotted abbreviations (e.g,i.e,p.4) no longer pass;cmd/root.go,llama.cpp, andexample.orgstill do.acronymStopwordsgains ordinary words written in capitals for emphasis or as labels (NEVER,ONLY,BOTH,PASS,NOTE,FIXED, ...). Words that double as technical names (HEAD,POST,PATH,HOME,REST,DELETE,LINE) stay out of the list, and real acronyms (API,HTTP,SQL) are unaffected.Why
The file-path pattern
([.\w/-]+\.\w{1,10})matches any dotted token, and the acronym pattern matches any 2-6 letter all-caps word. On a long-lived personal store of several thousand insights, about 3,700 stored entities were bare numbers,e.galone sat on nearly 500 insights, and the most frequent all-caps entities includedONLY,PASS,BOTH,NEVER, andLESSON, each on 200 to 350 insights. Every one of them becomes an entity edge between memories that share nothing but a decimal or an emphasis word. The frequency gate from #160 only filters the wide-cast path, so it does not catch these strict-regex matches.Effect
New writes and recall query entities stop admitting these tokens. Insights keep the entities they already stored, and edges built from them stay until a rebuild.
Validation
TestExtractEntities_FilePathsSkipNumbersAndAbbreviationsandTestExtractEntities_EmphasisWordsAreNotAcronymsfail on master ("0.52" must not be an entity,"NEVER" must not be an entity) and pass here.gofmt -lis clean andmake test(includinggo vet ./...) passes.Release note
Entity extraction no longer stores decimals, dotted abbreviations, or capitalized emphasis words as entities.