Skip to content

Speech targets fix#526

Merged
priyakasimbeg merged 43 commits intodevfrom
speech_targets_clean
Oct 5, 2023
Merged

Speech targets fix#526
priyakasimbeg merged 43 commits intodevfrom
speech_targets_clean

Conversation

@priyakasimbeg
Copy link
Contributor

@priyakasimbeg priyakasimbeg commented Oct 2, 2023 •
edited
Loading

Addresses issues in #513.

  • Override step_hints and targets in Deepspeech jax and pytorch workload classes. Without this fix the conformer properties are inherited.
  • Remove Deepspeech base workload class. This is misleading since the jax and pytorch workload classes inherit from the respective conformer workload classes, so the overrides in this class are not being used.
  • Fix hparams for target setting for speech workloads with reduced budgets.
  • Update target setting algorithm in README for conformer.

priyakasimbeg and others added 30 commits September 25, 2023 05:31
@priyakasimbeg
update tuning search spaces for speech_workloads
7970388
@priyakasimbeg
add tabulate for deepspeech debugging
862f500
@priyakasimbeg
update target setting algo for conformer to adamw
1816234
@priyakasimbeg
tabulate typo fix
6b9655f
@priyakasimbeg
typo
28db392
@priyakasimbeg
add lr logging target_setting nadamw
fab70f9
@priyakasimbeg
Merge branch 'speech_targets' of github.com:mlcommons/algorithmic-eff…
fc07904 
…iciency into speech_targets
@priyakasimbeg
reverse padding fixes
1ea08b0
@priyakasimbeg
log_step_hint
c3cf664
@priyakasimbeg
log step hint in submission runner
784230f
@priyakasimbeg
add logging
e83937b
@priyakasimbeg
lgoging
0606b01
@priyakasimbeg
logging
b23aae4
@priyakasimbeg
fix logging
27cb037
@priyakasimbeg
more logging;
a0c8624
@priyakasimbeg
remove inheritance
d977605
@priyakasimbeg
temp change to conformer
9749f00
@priyakasimbeg
fix step hint
869bdad
@priyakasimbeg
deepspeech inheritance fix
0a60f89
@priyakasimbeg
Merge branch 'dev' into speech_targets
54f3eb9
@priyakasimbeg
remove lr schedule logging
06df206
@priyakasimbeg
debugging statements
aa6c538
@priyakasimbeg
fix
3afcc9f
@priyakasimbeg
fix
3c72358
@priyakasimbeg
fix imports
bc55c34
@priyakasimbeg
import fix
1323b57
@priyakasimbeg
fix
0c67481
@priyakasimbeg
copy jax and pytorch loss_fn, model_fn and _eval_model_on_split to de…
1e44349 
…epspeech classes
@priyakasimbeg
fix imports
347d1df
@priyakasimbeg
fix block
f7789db
@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the title Speech targets clean Speech targets fix Oct 2, 2023
@priyakasimbeg priyakasimbeg marked this pull request as ready for review October 3, 2023 00:34
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner October 3, 2023 00:34
sourabh2k15
sourabh2k15 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@sourabh2k15 sourabh2k15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for catching this bug
hparam changes are also correct

@priyakasimbeg priyakasimbeg merged commit 8c642dc into dev Oct 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
@priyakasimbeg priyakasimbeg deleted the speech_targets_clean branch November 2, 2023 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sourabh2k15 sourabh2k15 sourabh2k15 approved these changes

@znado znado Awaiting requested review from znado

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@priyakasimbeg @sourabh2k15