Add machine-readable Code enum to flow.Error - #8321
Open
youdie006 wants to merge 2 commits into
Open
Conversation
Add a nested Error.Code enum (generic/killed/connection/timeout/protocol) so consumers can distinguish error categories while the human-facing msg is unchanged. Set the code at categorizable construction sites and bump the flow format with a 21->22 migration for back-compat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4554.
Adds a machine-readable category to
flow.Errorso consumers can distinguish interrupted connections, timeouts, and protocol errors, while the human-facingmsgis unchanged (as the issue requests).Error.Codeenum:GENERIC(default) /KILLED/CONNECTION/TIMEOUT/PROTOCOL. Nested to avoid colliding with the existing HTTPErrorCodeint enum.codefield is placed aftertimestampto preserve positional back-compat (Error(msg, ts)), andkill()setsKILLED. Codes are set at categorizable construction sites (connection-open failures -> CONNECTION, header validation / protocol errors -> PROTOCOL); GENERIC elsewhere.convert_21_22migration so existing.mitmfiles still load.Design follows the issue and the review on the earlier (abandoned) #5662: a GENERIC default instead of a required arg (no breaking change), KILLED unified into the enum, and the format migration.
Test plan
Added
test_flow.py::TestErrorcases (default/explicit/round-trip) andtest_compat.py::test_convert_21_22(red->green).test_flow.py+test_compat.py+test_io.py-> 33 passed; proxy layer tests -> 259 passed. ruff + mypy clean.AI disclosure: this PR was drafted with Claude Code (AI-assisted). Tests were run red->green locally (test_flow + test_compat independently re-verified: 21 passed).