Default text encoding to utf8 instead of (very) legacy latin-1#8126
Open
emaheuxPEREN wants to merge 1 commit intomitmproxy:mainfrom
Open
Default text encoding to utf8 instead of (very) legacy latin-1#8126emaheuxPEREN wants to merge 1 commit intomitmproxy:mainfrom
emaheuxPEREN wants to merge 1 commit intomitmproxy:mainfrom
Conversation
emaheuxPEREN
force-pushed
the
utf8_encoding_by_default
branch
5 times, most recently
from
37da891 to
1a6879b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
infer_content_encoding, we set the fallback encoding to the UTF-8 standard instead of the (very) legacy Latin-1 encoding.As a consequence,
get_text()outputs (and thus HAR dumps) may differ from previous version, advocating for more than a patch release.(Note that to reach full coverage I had to perform a mini-refact in
mitmproxy.io.har-> extract a little untested snippet into an unitary testable function)Checklist