Fix printf option parsing in cURL export for dash-prefixed data#8078
Open
veeceey wants to merge 3 commits intomitmproxy:mainfrom
Open
Fix printf option parsing in cURL export for dash-prefixed data#8078veeceey wants to merge 3 commits intomitmproxy:mainfrom
veeceey wants to merge 3 commits intomitmproxy:mainfrom
Conversation
…dash When exporting a request as a cURL command, if the POST body contained control characters and started with dashes (e.g. multipart boundaries like "---boundary"), the generated printf call would fail with "invalid option" because printf interpreted the leading dashes as flags. Adding `--` after `printf` signals end-of-options, preventing this error. Fixes mitmproxy#8050 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Friendly ping - any chance someone could take a look at this when they get a chance? Happy to make any changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.