fix: content encoding inference from meta tag, especially for various unusual format#8031
Open
edenw97 wants to merge 13 commits intomitmproxy:mainfrom
Open
fix: content encoding inference from meta tag, especially for various unusual format#8031edenw97 wants to merge 13 commits intomitmproxy:mainfrom
edenw97 wants to merge 13 commits intomitmproxy:mainfrom
Conversation
…ous unusual format(unquoted, whitespace), follows https://html.spec.whatwg.org/#extracting-character-encodings-from-meta-elements
mhils
reviewed
Jan 1, 2026
| match = meta_charset.group(2) or meta_charset.group(3) | ||
| if match: | ||
| enc = match.decode("ascii", "ignore").strip() | ||
| else: |
Member
There was a problem hiding this comment.
We already validated that meta_charset is not None, so can this case ever happen?
(charset="" would be an option, but then we should move the .strip() before the if as well)
Author
There was a problem hiding this comment.
Hi, do you mean move the strip() to before the decode?
Co-authored-by: Maximilian Hils <github@maximilianhils.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the content encoding inference from meta tag, especially for various unusual format(unquoted, whitespace), follows https://html.spec.whatwg.org/#extracting-character-encodings-from-meta-elements
Description
this PR address multiple edge case when we infer content-encoding in the meta tag
Checklist