added clearer error hint for wireguard port conflicts#7994
Open
jagadeeshkaruturi11 wants to merge 1 commit intomitmproxy:mainfrom
Open
added clearer error hint for wireguard port conflicts#7994jagadeeshkaruturi11 wants to merge 1 commit intomitmproxy:mainfrom
jagadeeshkaruturi11 wants to merge 1 commit intomitmproxy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey! i noticed in issue #7650 that the error message for WireGuard port conflicts wasn't super clear - it just said to try a different port but didn't mention that you might already have WireGuard running which is a common cause.
so i added a quick check that when we detect a port conflict AND we're in WireGuard mode, we now tell users "If you already have WireGuard running, stop it first or use a different port."
should help folks troubleshoot faster instead of scratching their heads about why the port's already taken.
let me know if you want me to change anything!