⚡️ Speed up _sanitize_tag_value() by 1,043% in sentry_sdk/metrics.py
#8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_sanitize_tag_value()insentry_sdk/metrics.py📈 Performance improved by
1,043%(10.43xfaster)⏱️ Runtime went down from
39.3 millisecondsto3.44 millisecondsExplanation and details
Sure, here is an optimized version of the given program.
The primary optimization here is to replace multiple successive invocations and the intermediate translation table setup with a chain of
.replace()calls. This approach eliminates the need to first create a translation table and then translate all characters in one pass, thus reducing overhead and improving performance.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
🔘 (none found) − ⚙️ Existing Unit Tests
✅ 37 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests