⚡️ Speed up _strip_pii() by 12% in sentry_sdk/integrations/pymongo.py
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_strip_pii()insentry_sdk/integrations/pymongo.py📈 Performance improved by
12%(0.12xfaster)⏱️ Runtime went down from
6.47 millisecondsto5.77 millisecondsExplanation and details
Here is a more optimized version of your code.
Performance Improvements.
SAFE_COMMAND_ATTRIBUTES: Membership checks are faster with sets compared to lists because they use a hash table.list(command)in the for-loop: This prevents issues that can arise from modifying the dictionary size during iteration.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
✅ 23 Passed − ⚙️ Existing Unit Tests
(click to show existing tests)
✅ 29 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests